Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove octal literals #28

Closed
wants to merge 1 commit into from
Closed

remove octal literals #28

wants to merge 1 commit into from

Conversation

goya
Copy link

@goya goya commented Oct 27, 2016

allows strict mode support.

@thejoshwolfe
Copy link
Owner

Great idea. I hate octal literals, but unix permissions still seems like a legitimate usecase to me.

I've replaced the octal literals with calls to parseInt() with an explicit radix of 8. Aside from the tiny increase in startup time, my idea is functionally identical to yours, and it still keeps the octal syntax for readability.

Thanks for the PR anyway.

@goya
Copy link
Author

goya commented Oct 27, 2016

no worries. let and const wait for no person. cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants