ignore 'unexpected EOF' in Extra Field buffer. closes #31

thejoshwolfe · Jun 8, 2016 · 61c40fd · 61c40fd
1 parent a525eed
commit 61c40fd
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/index.js b/index.js
@@ -280,8 +280,7 @@ ZipFile.prototype.readEntry = function() {
       var extraFieldBuffer = buffer.slice(entry.fileNameLength, fileCommentStart);
       entry.extraFields = [];
       var i = 0;
-      while (i < extraFieldBuffer.length) {
-        if (i >= extraFieldBuffer.length - 4) return emitErrorAndAutoClose(self, new Error("unexpected end of Extra Field buffer"));
+      while (i < extraFieldBuffer.length - 3) {
         var headerId = extraFieldBuffer.readUInt16LE(i + 0);
         var dataSize = extraFieldBuffer.readUInt16LE(i + 2);
         var dataStart = i + 4;

diff --git a/test/failure/unexpected end of Extra Field buffer.zip b/test/failure/unexpected end of Extra Field buffer.zip