Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust to build chain #778

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add rust to build chain #778

wants to merge 2 commits into from

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Jul 17, 2024

Hopefully fixes uv

@github-actions github-actions bot added the enhancement New feature or request label Jul 17, 2024
Signed-off-by: zethson <[email protected]>
@eroell
Copy link
Collaborator

eroell commented Oct 10, 2024

@flying-sheep mentioned with uv we might need to pin minimum versions of some dependencies.... I'll have a look at this soon

@flying-sheep
Copy link

flying-sheep commented Oct 10, 2024

To elaborate: uv just has a slightly(?) different dependency resolution algorithm from pip. So the versions that get downloaded (potentially built) and then considered for dependency resolutions are different. So:

  1. if a failure happens during dependency resolution, uv/pip might be trying to build some ancient version of something. If you use the tool in verbose mode you can catch that and maybe circumvent by setting minimum versions or a constraint file, e.g. via the UV_CONSTRAINT env var.
  2. If a failure happens during runtime, maybe it’s just that uv resolved the environment with different versions than pip.

Important

Generally, most Rust-based Python packages have frequent releases and great automation, resulting in binary wheels being available. The fact that something tries to build Rust code might be fishy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants