Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate vibrio characterisation with srst2 into TheiaProk workflows #216
Incorporate vibrio characterisation with srst2 into TheiaProk workflows #216
Changes from 28 commits
7c12fee
40ae0db
904ba4e
8b93c5f
c629fa5
eb77bf9
e6ae8a2
4cbb1ee
ed44e6e
74fadcf
8980632
bebfaa8
9d9b75d
1ffd357
e07446d
9b762a6
5cea6c5
8b33b5a
c1a0b7b
99d01e0
6db886c
13abff2
0e29cea
33d5f66
4e4116a
ccad72a
c6cc642
3029eea
32068c3
4c1e70c
a7ad2ff
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So good! For future iterations, I'm thinking that it may be helpful to package all of this gene-type parsing into a single executable that can be made available in the docker image itself to promote interoperability of this specific functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it should be increased further
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emmadoughty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resloved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that the validation runs linked above don't have these values set by merlin magic--which leads me to assume that they're just using default srst2 values (i.e. 10).