fix the debug stop button remains opaque #5933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix eclipse-theia#5930 When the debug button is clicked, the debug button remains opaque and will be transparent only after another click event occurred in the same page. This commit is going to override opacity style of :focus css class. Signed-off-by: tom-shan <[email protected]>
vince-fugnitto
approved these changes
Aug 13, 2019
There was a problem hiding this comment.
I tested the changes and the debug buttons are correctly displayed (transparent and opaque) when it is necessary.
Test Case
- start a debug session ('run mocha test')
- debug widget stop button is opaque
- click the stop button
- stop button becomes transparent
This test case fails on master as the button remains opaque.
|
@vince-fugnitto don't forget to help with merging |
Yes of course, just waited to see if anyone else had additional comments (although the change is in fact minimal and can be merged without objections) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5930
What it does
When the debug button is clicked, it remains opaque and will be
transparent only after another click event occurred in the same page.
This commit is going to override opacity style of
:focuscss class.How to test
Please follow the
Reproduction Stepsin the original issue and check if it is fixed.Review checklist
Reminder for reviewers