Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug button remains opaque #5930

Closed
tom-shan opened this issue Aug 13, 2019 · 1 comment · Fixed by #5933
Closed

Debug button remains opaque #5930

tom-shan opened this issue Aug 13, 2019 · 1 comment · Fixed by #5933
Labels
bug bugs found in the application debug issues that related to debug functionality help wanted issues meant to be picked up, require help

Comments

@tom-shan
Copy link
Contributor

tom-shan commented Aug 13, 2019 •
edited
Loading

Description

When the debug button is clicked, this button remains opaque and will be
transparent only after another click event occurred in the same page.
debug-button

Reproduction Steps

1 start debug session, you can use this node demo repo
2 click stop button
3 the stop button will never be transparent until you click anywhere in the same page.

OS and Theia version:
OS: ubuntu 18.04
Theia version: master 11badc

Diagnostics:

this issue may be related to 2e1d719#diff-cb367aa6c86884a6382b29179659ffd8R113
@akosyakov akosyakov added bug bugs found in the application debug issues that related to debug functionality help wanted issues meant to be picked up, require help labels Aug 13, 2019
@akosyakov
Copy link
Member

PRs are welcomed.

@tom-shan maybe you can tweak styles a bit in the debug extension to fix it

tom-shan added a commit to tom-shan/theia that referenced this issue Aug 13, 2019
@tom-shan
fix the debug stop button remains opaque
d717414 
Fix eclipse-theia#5930

When the debug button is clicked, the debug button remains opaque and will be
transparent only after another click event occurred in the same page.
This commit is going to override opacity style of :focus css class.

Signed-off-by: tom-shan <[email protected]>
@tom-shan tom-shan mentioned this issue Aug 13, 2019
Merged
1 task
vince-fugnitto pushed a commit that referenced this issue Aug 13, 2019
@tom-shan @vince-fugnitto
fix the debug stop button remains opaque
b7d7023 
Fix #5930

When the debug button is clicked, the debug button remains opaque and will be
transparent only after another click event occurred in the same page.
This commit is going to override opacity style of :focus css class.

Signed-off-by: tom-shan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application debug issues that related to debug functionality help wanted issues meant to be picked up, require help
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix the debug stop button remains opaque tom-shan/theia
2 participants
@akosyakov @tom-shan