[workspace] do not re-open an already currently opened workspace

[vince-fugnitto]

Fixes #5630

Description

• fixes an issue that allows users to open a workspace that is currently opened. If the user had the preference "workspace.preserveWindow" set to false it would open an identical workspace in a new tab, and if it was set to true it would reload the workspace. Instead, an additional
  check is performed to determine if the current workspace and the new destination are equal, and if they are a NOOP is instead performed by returning undefined.
• fixes issue present in OPEN and OPEN_WORKSPACE for both the browser and electron based applications.

The PR was tested with both folders, files, and multi-root workspaces on both the browser and electron.

How to test

1. open a workspace (ex: A)
2. attempt to re-open the workspace A using the menu File and Open
3. the workspace should not be re-opened in a new tab or the current one should not be reloaded depending on the preference workspace.preserveWindow

Signed-off-by: Vincent Fugnitto [email protected]

[kittaakos]

It did not work for me. Am I missing something?

[vince-fugnitto]

It did not work for me. Am I missing something?

No you're not missing anything, I'm missing something as I only updated the OPEN and not also the OPEN_WORKSPACE which can be both used.

[kittaakos]

I propose checking the URI only and not the entire FileStat. Why? Because we do not want to compare the lastModification. When we open a new workspace we kind of cache the FileStat (which could be good or bad I do not know) as is; with the lastModification. When I create a new file in the root, I will get back a new, updated FileStat but no one updates the cached FileStat representing the workspace root. When we compare them, they won't be equal as the lastModification will be different.

Steps to reproduce.

• Open a WS.
• Reopen the same WS => NOOP => ✅
• Create a new file inside the WS root.
• Reopen the same WS => Opens a new workspace => ❌

Thoughts?

[vince-fugnitto]

I propose checking the URI only and not the entire FileStat...

Sure makes sense!

[kittaakos]

I have tested it again and it worked. Thank you!

[vince-fugnitto]

@kittaakos thank you!