(Re-)Opening a currently opened workspace should be NOOP #5630
Assignees
Labels
bug
bugs found in the application
help wanted
issues meant to be picked up, require help
workspace
issues related to the workspace
Comments
akosyakov
added
bug
vince-fugnitto
added a commit
that referenced
this issue
Jul 3, 2019
Fixes #5630 - fixes an issue that allows users to open a workspace that is currently opened. If the user had the preference `"workspace.preserveWindow"` set to `false` it would open an identical workspace in a new tab, and if it was set to `true` it would reload the workspace. Instead, an additional check is performed to determine if the current workspace and the new destination are equal, and if they are a NOOP is instead performed by returning `undefined`. Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto
added a commit
that referenced
this issue
Jul 3, 2019
Fixes #5630 - fixes an issue that allows users to open a workspace that is currently opened. If the user had the preference `"workspace.preserveWindow"` set to `false` it would open an identical workspace in a new tab, and if it was set to `true` it would reload the workspace. Instead, an additional check is performed to determine if the current workspace and the new destination are equal, and if they are a NOOP is instead performed by returning `undefined`. - fixes issue present in `OPEN` and `OPEN_WORKSPACE`. Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto
added a commit
that referenced
this issue
Jul 3, 2019
Fixes #5630 - fixes an issue that allows users to open a workspace that is currently opened. If the user had the preference `"workspace.preserveWindow"` set to `false` it would open an identical workspace in a new tab, and if it was set to `true` it would reload the workspace. Instead, an additional check is performed to determine if the current workspace and the new destination are equal, and if they are a NOOP is instead performed by returning `undefined`. - fixes issue present in `OPEN` and `OPEN_WORKSPACE` for both the browser and electron based applications. Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto
added a commit
that referenced
this issue
Jul 4, 2019
Fixes #5630 - fixes an issue that allows users to open a workspace that is currently opened. If the user had the preference `"workspace.preserveWindow"` set to `false` it would open an identical workspace in a new tab, and if it was set to `true` it would reload the workspace. Instead, an additional check is performed to determine if the current workspace and the new destination are equal, and if they are a NOOP is instead performed by returning `undefined`. - fixes issue present in `OPEN` and `OPEN_WORKSPACE` for both the browser and electron based applications. Signed-off-by: Vincent Fugnitto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
It should be a NOOP when I open a workspace that is already opened. At least, this is how it works from the
Open Recent Workspace...command, and it makes sense.Instead of the expected behavior, it opens the same workspace in a new tab:
The text was updated successfully, but these errors were encountered: