This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
Update Dockerfile language server #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Project does not compile without this change. The typescript version used here is the version currently used in Theia (see: eclipse-theia/theia@a2d89c8#diff-b9cfc7f2cdf78a7f4b91a753d10865a2L41). Signed-off-by: Cornelius A. Ludmann <[email protected]>
Signed-off-by: Cornelius A. Ludmann <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The used Dockerfile language server has got a lot of bug fixes and improvements since version 0.0.18. This PR updates the dependency to the newest version 0.0.21.
See also the changelog of the Dockerfile language server.
I tested the change by compiling in Gitpod and opening / editing a Dockerfile with the included browser-app. It turns out that the TypeScript version has to be updated in order to compile. I tested with 'next' as well as with 'latest'.