-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add matomo tracking to genetics app #4
Conversation
@RobinM-code (and others) see changes in last commit + related commit in otg-automation. this doesn't seem to work, i.e. I can install Matomo but it doesn't seem to track user activity. I tried several variations without success. |
I just pushed some changes (thanks @fedde-s) to use string replacement to replace the Matomo placeholder value with the URL provided by the user, only if Matomo is enabled; the string replacement takes place in the docker-compose, so it won't be possible to test Matomo with yarn unless one adds the desired Matomo URL to init_matomo.js manually. See also last commits to otg-automation PR |
We've since solved it in a different way, but for context on why I expect it didn't work: |
Ready for final review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfecto!
Relates to https://github.com/thehyve/opentargets-genetics-automation/pull/34
Original issue description