Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline diana #12

Open
wants to merge 9 commits into
base: timeline-diana
Choose a base branch
from
Open

Timeline diana #12

wants to merge 9 commits into from

Conversation

alisman
Copy link

@alisman alisman commented Aug 18, 2020

Fix cBioPortal/cbioportal# (see https://help.github.com/en/articles/closing-issues-using-keywords)

Describe changes proposed in this pull request:

  • a
  • b

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

Adam Abeshouse and others added 9 commits August 13, 2020 17:08
Flip timeline tooltip placement according to mouse position so its al…
84be031 
…ways onscreen

Signed-off-by: Adam Abeshouse <[email protected]>
Upper case track names instead of capitalizing
b4330ef 
Signed-off-by: Adam Abeshouse <[email protected]>
Special black colored icon for multiple events, to avoid color confusion
47ce08f 
Signed-off-by: Adam Abeshouse <[email protected]>
Oops - only show lines for line chart tracks
9908634 
Signed-off-by: Adam Abeshouse <[email protected]>
Collapse lone OTHER tracks
ff1f715 
Signed-off-by: Adam Abeshouse <[email protected]>
@alisman
Merge pull request #34 from adamabeshouse/tali-fixes
e733e03 
Fixes 4-7
@alisman
Added VAF Chart to Summary Patient View using new timeline axis
f4956f6 
- Chart has the highlighting, tooltips and click functionality just like
old VAF chart
- Samples appear one under the other when having same start date
- A "Group by" control has been added to group samples by selected
clinical attribute (rfc 54). Samples appear on different rows depending on
category and have different colors. Labels are not in proper place (TBD)
- Fixed review comments from Aaron and Adam and added all VAF chart controls
@alisman
Hide labels option
15e3e47
@alisman
Allow for isolation of custom tracks in Timeline
d004159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alisman