Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilities clean up #9

Merged
merged 13 commits into from
Jun 24, 2021
Merged

Utilities clean up #9

merged 13 commits into from
Jun 24, 2021

Conversation

egarcialara
Copy link

For some reason it seems like all the file was edited, but I only made each utility into a function

MaximMoinat
MaximMoinat suggested changes Jun 24, 2021
View reviewed changes
Copy link

@MaximMoinat MaximMoinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestions in the comments. It would be good to add a documentation for each function like shown for compareResults. Especially for editThresholds.R including an @example would be helpful.

extras/compareResults.R Outdated Show resolved Hide resolved
extras/conceptMappingCoveragePerDomain.R Outdated Show resolved Hide resolved
extras/edit_thresholds/editThresholds.R Outdated Show resolved Hide resolved
extras/compareResults.R Outdated Show resolved Hide resolved
extras/compareResults.R Outdated Show resolved Hide resolved
extras/compareResults.R Outdated Show resolved Hide resolved
MaximMoinat
MaximMoinat approved these changes Jun 24, 2021
View reviewed changes
Copy link

@MaximMoinat MaximMoinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🌈

@MaximMoinat MaximMoinat merged commit 1de0cc0 into utilities Jun 24, 2021
@MaximMoinat MaximMoinat deleted the utilities-clean-up branch September 15, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximMoinat MaximMoinat MaximMoinat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egarcialara @MaximMoinat