-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix join of DQD results for compare #6
Conversation
While doing a general code cleanup I encountered another issue: |
I think this is because the colors are given as a list, so usually Fails takes chocolate1, but if there's no Fail, Pass takes it as first in the list. I'll make an edit about it! (See #7 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After merging the two dependent PR, this can be solved :)
fix colours in plot
fix no differences by adding mock point
Corrected calculation errors and aggregated vs grouped in ReactTable
This caused mismatches in the join of concept level checks.
@elena: another issue I encountered is that the script gives an error if there are no differences between the DQD results (as in
combined_results
is empty after the filter)