Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix join of DQD results for compare #6

Merged
merged 11 commits into from
Jun 21, 2021
Merged

Conversation

MaximMoinat
Copy link

This caused mismatches in the join of concept level checks.

@elena: another issue I encountered is that the script gives an error if there are no differences between the DQD results (as in combined_results is empty after the filter)

@MaximMoinat MaximMoinat requested a review from egarcialara June 14, 2021 12:12
@MaximMoinat
Copy link
Author

While doing a general code cleanup I encountered another issue:
Normally passes are darkblue, fails chocolate1. However, when all checks pass, the passes become chocolate1. @egarcialara Any idea?

@egarcialara
Copy link

egarcialara commented Jun 15, 2021

While doing a general code cleanup I encountered another issue:
Normally passes are darkblue, fails chocolate1. However, when all checks pass, the passes become chocolate1. @egarcialara Any idea?

I think this is because the colors are given as a list, so usually Fails takes chocolate1, but if there's no Fail, Pass takes it as first in the list. I'll make an edit about it! (See #7 )

@egarcialara
Copy link

@elena: another issue I encountered is that the script gives an error if there are no differences between the DQD results (as in combined_results is empty after the filter)

Solved in #8

Copy link

@egarcialara egarcialara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging the two dependent PR, this can be solved :)

@egarcialara egarcialara merged commit 6561af4 into utilities Jun 21, 2021
@egarcialara egarcialara deleted the fix-dqd-compare branch June 21, 2021 14:37
MaximMoinat pushed a commit that referenced this pull request Apr 13, 2022
Corrected calculation errors and aggregated vs grouped in ReactTable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants