Edit thresholds #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'edit_thresholds' of https://github.com/thehyve/DataQualityDashboard into edit_thresholds # Conflicts: # extras/edit_thresholds/README.md
MaximMoinat
reviewed
May 6, 2021
Comment on lines
8
to
17
| # 1) get longer table | ||
| df_long <- pivot_longer_func(file) | ||
| write.csv(df_long, file.path(getwd(), "dflong.csv")) | ||
|
|
||
| # 2) Edit thresholds, in 'df_long' directly or in excel file 'dflong.csv' | ||
| # using the indexes selected using file_thresholds & printed here: | ||
| # (be aware that the excel file might have one extra row for column names, see the index in the first column!!) | ||
| file_thresholds <- "thresholds_to_add.csv" | ||
| print_threshold_location(df_long, file_thresholds) | ||
|
|
There was a problem hiding this comment.
This feels like double work; first creating a file with what thresholds you want to change, then looking it up in dflong.csv, and entering the threshold percentage.
Ideally you already add the threshold in the input file:
| Level | Check_name | cdmTableName | cdmFieldName | fkTableName | fkDomain | threshold | note |
|---|---|---|---|---|---|---|---|
| Field | isRequired | MEASUREMENT | person_id | 35 |
Then we can also automate steps 2+3, where the script first looks up the index of the check and then fills in the threshold and note.
There was a problem hiding this comment.
I avoided it so that the Notes don't get duplicated in the case of multiple runs. It's corrected now
There was a problem hiding this comment.
How would notes get duplicated? The way I see it, an existing note in this file can just be updated in a next run.
|
Oh la la!
|
MaximMoinat
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overkill? maybe. But now it's done 🤷♀️