-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add marginal carbon intensity data from UNFCCC #102
Conversation
@mrchrisadams This PR is ready for review. It exposes the UNFCCC data in JSON format, just like we have done for Ember in #69. In order to do this, I have:
|
I have also added JSDoc style comments to the utility functions, which should help us when we come back to this code later & help others who want to play with it too. I'll try to do this more often as I touch other parts of the CO2.js code base, so that we can gradually have more complete documentation throughout the library. |
@mrchrisadams this should be all set now with the changes we discussed yesterday for #104 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @fershad I'm happy for this to be merged in.
Thanks for putting the work in.
There are a lot of commits in this PR, and it doesn't look like we can rebase these in. I'm happy with a squash commit if it makes it easier to get this into the main branch, for us to start thinking about how to use this data in an extended API.
This PR adds country level marginal carbon intensity data from the UNFCCC to CO2.js. Initially (in this PR) we will be including the source data, and introducing scripts to generate JSON and JS exports of the source CSV file.
Todo: