-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
@emckean Looks like you committed node_modules. |
yeah the PR panel can't load the |
adding node_modules to .gitignore
@@ -0,0 +1,28 @@ | |||
# How to Contribute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should replace this with our CONTRIBUTING.md
doc? looks like it is an artifact from a google project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, I think you're right ... I must have git-added it after removing the cached node-modules. I'll remove!
@@ -2,3 +2,4 @@ _site | |||
.sass-cache | |||
.jekyll-metadata | |||
.DS_Store | |||
node_modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This helped took us from 11k down to 7.3k. Still lots of files in the themes/
which looks like it is sub-linked as a github-submodule. I don't know enough about Hugo to know if those are all-required? Or those could be sourced as part of the envrionment setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me find out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to gitignore the docsy theme folder, since this usually pulls in with a recursive submodule pull during the clone operation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! I will run a diff first to make sure I didn't "improve" anything in the standard theme 😂
@emckean I have started a new repo/project in the org for the Hugo+Docsy site. |
I've made PR for a new branch, to move the content over, clone this branch and edit :)