Skip to content
This repository has been archived by the owner on Apr 22, 2021. It is now read-only.

create a Docsy version of the site #40

Closed
wants to merge 6 commits into from

Conversation

emckean
Copy link
Contributor

@emckean emckean commented Aug 19, 2020

I've made PR for a new branch, to move the content over, clone this branch and edit :)

@bwklein
Copy link
Member

bwklein commented Sep 3, 2020

@emckean Looks like you committed node_modules.
I'd recommend updating your gitignore and trimming this PR down a bit.

@mgan59
Copy link
Contributor

mgan59 commented Sep 15, 2020

yeah the PR panel can't load the diff because there are over 10k files in it.

emckean and others added 2 commits September 15, 2020 11:54
@@ -0,0 +1,28 @@
# How to Contribute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should replace this with our CONTRIBUTING.md doc? looks like it is an artifact from a google project?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I think you're right ... I must have git-added it after removing the cached node-modules. I'll remove!

@@ -2,3 +2,4 @@ _site
.sass-cache
.jekyll-metadata
.DS_Store
node_modules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helped took us from 11k down to 7.3k. Still lots of files in the themes/ which looks like it is sub-linked as a github-submodule. I don't know enough about Hugo to know if those are all-required? Or those could be sourced as part of the envrionment setup.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me find out!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to gitignore the docsy theme folder, since this usually pulls in with a recursive submodule pull during the clone operation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! I will run a diff first to make sure I didn't "improve" anything in the standard theme 😂

@bwklein
Copy link
Member

bwklein commented Oct 28, 2020

@emckean I have started a new repo/project in the org for the Hugo+Docsy site.
I'm closing this PR and would like to spin up a new clean site there to migrate content from this repo into.

@bwklein bwklein closed this Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants