Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

merge contrib guide from incubator #172

Merged
merged 4 commits into from
Dec 7, 2020
Merged

merge contrib guide from incubator #172

merged 4 commits into from
Dec 7, 2020

Conversation

Loquacity
Copy link
Member

@Loquacity Loquacity commented Nov 29, 2020

ALL Pull-Requests require an associated Issue as documented in How to contribute.

Resolves: #171

Purpose / why

We have several locations with Contributors' Guides, this PR aligns the content in a single place.

What changes were made?

  • Content copied from Incubator repo base-template/contributors-guide.md to Template repo CONTRIBUTING.md
  • Some light editing to ensure the content flows correctly
  • Moved CONTRIBUTING.md to .github/CONTRIBUTING.md so that it appears in the Insights tab and is inherited across all the project repos.

Still to do:

Verification

  • Review the content of the guide.
  • Ensure it is in the correct location.

Checklist

Pull-request reviewer should ensure the following

  • Are issues linked correctly?
  • Is this PR labeled correctly?
  • If template updates: do they align with developers.google.com/style/?
  • Did the PR receive at least one 👍 and no 👎 from core-maintainers?
  • On merging, did you complete the merge using keywords?
  • On merging, did you add any applicable notes to a draft release and link to this PR?

Copy link
Contributor

@barbaricyawps barbaricyawps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one minor issue!

.github/CONTRIBUTING.md Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@Loquacity Loquacity merged commit f654556 into master Dec 7, 2020
@Loquacity Loquacity deleted the contrib-loquacity branch December 7, 2020 00:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align Contributors' Guides
3 participants