Add unique identifier to typeclass symbol names #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a unique tag to the typeclass symbol names because sometimes build systems will mangle the class names. What was happening was that `Functor` and `Filterable` were unique within their own scopse, so the class name became “e”. That caused funcadelic to look up the instance for `Functor` and getting `Filterable` because they both had `"@@funcadelic-0/e"` as their symbol name
|
I don't see any far reaching concerns, but then I didn't predict this predicament either? /cc @taras |
taras
requested changes
Jul 6, 2018
There was a problem hiding this comment.
Redux uses a technique to check if names have been mangled to detect when non production build is used in production mode. We could use the same technique to check if names have been mangled.
We could use the same technique to check if we need to add these unique identifiers. What do you think?
If they are being altered then we add the uniqueTag to the typeclass symbol name
|
@Robdel12 can we do the following? let name = hasBeenMangled ? uniqueTag++ : Class.name; |
taras
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This adds a unique tag to the typeclass symbol names because sometimes
build systems will mangle the class names.
What was happening was that
FunctorandFilterablewere uniquewithin their own scopse, so the class name became “e”. That caused
funcadelic to look up the instance for
Functorand gettingFilterablebecause they both had"@@funcadelic-0/e"as theirsymbol name