Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for 3.13 #2196

Merged

Conversation

ColeHiggins2
Copy link
Contributor

No description provided.

@ColeHiggins2 ColeHiggins2 self-assigned this Nov 7, 2024
@ColeHiggins2 ColeHiggins2 requested a review from ekohl November 7, 2024 20:21
@ColeHiggins2
Copy link
Contributor Author

@ekohl Do we want to add anything to the headline features, deprecations, and upgrade warnings?

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a note that Debian 11 is deprecated and will be dropped with Foreman 3.14, but I can do that tomorrow if you'd like. Some inline notes to improve readability.

_includes/manuals/3.13/1.2_release_notes.md Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think line 3 (This section will be updated prior to the next release.) should be removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be explicit, that's this line:

This section will be updated prior to the next release.

@ekohl
Copy link
Member

ekohl commented Nov 13, 2024

If you agree, could you merge & include theforeman/foreman-documentation#3452 here? Note this site doesn't have ifdef support so just include it unconditionally.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see #2196 (comment) resolved before we announce, but the PR in itself is correct.

@ColeHiggins2
Copy link
Contributor Author

@ekohl Just updated. Must have missed that comment

@ColeHiggins2 ColeHiggins2 requested a review from ekohl November 14, 2024 16:35
@ColeHiggins2 ColeHiggins2 merged commit d013905 into theforeman:gh-pages Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants