-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hammer plugin for foreman_webhooks #977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add an acceptance test for it? https://github.com/theforeman/puppet-foreman/blob/master/spec/acceptance/foreman_cli_plugins_spec.rb should be the place for that.
b07cf53
to
887b484
Compare
@ekohl, I guess done... |
Looks like there is no package on EL8. theforeman/foreman-packaging@b768dc0 probably hasn't triggered a rebuild in koji. This is something the packaging team needs to fix. And I guess it's not packaged at all on Debian-based distros. Do you want to address that or change the tests to only test on RPMs? |
http://koji.katello.org/koji/buildinfo?buildID=66308 exists, https://ci.theforeman.org/job/foreman-plugins-nightly-rpm-pipeline/681/ will publish it. |
I'll try to setup a Debian VM in the next few days to create a PR for packaging. |
@ekohl here is packaging PR for Debian: theforeman/foreman-packaging#6952 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I restarted the tests since the packages should be available now.
That passed, thanks! |
@ekohl, as you mentioned in theforeman/foreman-installer#702 (comment), what branch should I use to open a CP PR against? I need this plugin to be available for installation through installer for 2.5/6.10. |
No description provided.