Drop listen_on_interface #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehelms
approved these changes
Dec 19, 2019
|
tests fail 💔 |
This parameter doesn't work well since you need to configure Apache slightly different as well since out of the box it doesn't work. Users who care about this functionality can use Hiera with the http_vhost_options and https_vhost_options parameters to set the ip directly.
|
Rebased to fix the merge conflict and updated the tests. |
|
merged, bedankt @ekohl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter doesn't work well since you need to configure Apache slightly different as well since out of the box it doesn't work. Users who care about this functionality can use Hiera with the
http_vhost_optionsandhttps_vhost_optionsparameters to set the ip directly.