Use stricter datatypes #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean797
suggested changes
Sep 13, 2018
manifests/config/passenger.pp
Outdated
| @@ -68,8 +68,8 @@ | |||
| String $priority = $::foreman::vhost_priority, | |||
| String $servername = $::foreman::servername, | |||
There was a problem hiding this comment.
See, I said there are probably more fields :) Good one.
ekohl
force-pushed
the
use-datatypes
branch
from
ce44541
to
2ce5003
Compare
|
Also changed the |
ekohl
force-pushed
the
use-datatypes
branch
from
2ce5003
to
2ba38fb
Compare
ekohl
force-pushed
the
use-datatypes
branch
from
2ba38fb
to
3351abf
Compare
|
@ekohl What's the status here? Still WIP? |
|
No, I think this can be merged. Even if I missed a few, I think this can be reviewed to be merged. |
|
merged, bedankt @ekohl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps there are more fields that can use better data types.