Refactor Puppet handling #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lint fails |
|
Looks like I accidentally removed a bunch of code that would have broken otherwise. That was not intentional. |
|
This should wait on theforeman/foreman#5588 I guess? |
|
I'm not sure. While that variable is used by Foreman to determine defaults for other values, we don't really use the value because ssl certs are explicitly configured. That's why I'm slightly in doubt about it. |
This moves all puppetmaster defaults to its own parameters file. Parameters that were used in both are duplicated. It also adds Puppet types to all parameters. This removes puppet settings from the top level. The puppet_ssldir is now an internal detail to determine defaults. It is also no longer set in Foreman since it's only used as a base for determining SSL paths which we explicitly set. There is a PR open to remove this setting altogether.
ehelms
approved these changes
Aug 20, 2018
|
@mmoll do you want to wait for the core merge or can we merge this now? IMHO both are ready to be merged now. |
|
merged, bedankt @ekohl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all puppetmaster defaults to its own parameters file.
Parameters that were used in both are duplicated. It also adds Puppet
types to all parameters.
This removes puppet settings from the top level. The puppet_ssldir is
now an internal detail to determine defaults. It is also no longer set
in Foreman since it's only used as a base for determining SSL paths
which we explicitly set. There is a PR open to remove this setting
altogether.