Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require steps to be explicitly marked as skippable for whitelisting #714

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Apr 3, 2023

This makes a change to whitelist logic to require steps to be explicitly marked as 'skippable' in the code to be whitelistable by users. Previously, everything was assumed to be skippable and steps had to be marked that they could not be whitelisted. This can lead to steps in processes like upgrades being skipped by users when they should not be causing more problems.

This may have an impact on users used to skipping certain steps, but will enforce more forethought on what a user should be able to skip.

I am starting this as a draft, as it's a reversal of logic, and should include a review of all possible steps that we may deem skippable at the outset. This is also a bit tricky because there may be cases where the step and the context have to be taken into consideration -- which this solution does not provide an answer for at present.

Steps that have currently been marked skippable were pulled from our documentation.

This makes a change to whitelist logic to require steps to be
explicitly marked as 'skippable' in the code to be whitelistable by
users. Previously, everything was assumed to be skippable and steps
had to be marked that they could not be whitelisted. This can lead
to steps in processes like upgrades being skipped by users when they
should not be causing more problems.

This may have an impact on users used to skipping certain steps, but
will enforce more forethought on what a user should be able to skip.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants