Fixes #36799 - Add Salt image path to ConfigReportsController #9849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36799 |
bastian-src
changed the title
ekohl
requested changes
Oct 4, 2023
bastian-src
force-pushed
the
salt_fix_report_origin_icon
branch
from
ec65d20
to
c8cde58
Compare
sbernhard
previously approved these changes
Oct 4, 2023
ekohl
previously approved these changes
Oct 4, 2023
|
@bastian-src GitHub has PR drafts (https://github.blog/2019-02-14-introducing-draft-pull-requests/) and these days we use those instead of |
|
Alright, thanks! I've marked it as a draft again to add a test. |
bastian-src
changed the title
bastian-src
force-pushed
the
salt_fix_report_origin_icon
branch
from
c8cde58
to
1b85e53
Compare
|
@ekohl I've added some tests here, but I'm a but unsure how good/ok they are 🤞 |
bastian-src
force-pushed
the
salt_fix_report_origin_icon
branch
from
1b85e53
to
f8a8ac9
Compare
bastian-src
force-pushed
the
salt_fix_report_origin_icon
branch
from
f8a8ac9
to
6d3a973
Compare
bastian-src
force-pushed
the
salt_fix_report_origin_icon
branch
from
6d3a973
to
ade8f9d
Compare
ekohl
approved these changes
Oct 5, 2023
|
Tests are through. The failed test should be something different and not releated to this issue. @ekohl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Salt reports, no icon is printed in the "origins" column.
This PR adds the Salt image path to the
ConfigReportsController. The image is already part of Foreman core.(It has probably been forgotten when adding the Reports tab to the new host details page here: 616c0d3)