Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36791 - Fix typo in variable name #9846

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

maximiliankolb
Copy link
Contributor

@maximiliankolb maximiliankolb commented Sep 28, 2023

I found this while looking for another issue when creating an organization.

@evgeni
Copy link
Member

evgeni commented Sep 29, 2023

Can you please create a dedicated redmine and mark that as fixed in the PR? As it is a bug :)

@evgeni evgeni self-assigned this Sep 29, 2023
@ekohl
Copy link
Member

ekohl commented Sep 29, 2023

To elaborate: we use Fixes if it closes an issue. An issue can only be closed once and the issue you mention has been closed in 2015, so you use a new issue.

@maximiliankolb maximiliankolb changed the title Refs 7096 - Fix typo in variable name Fixes 36791 - Fix typo in variable name Sep 29, 2023
@maximiliankolb
Copy link
Contributor Author

Created an issue and referenced it in my commit message.

@evgeni evgeni changed the title Fixes 36791 - Fix typo in variable name Fixes #36791 - Fix typo in variable name Sep 29, 2023
@evgeni evgeni merged commit 300efc3 into theforeman:develop Sep 29, 2023
9 checks passed
@maximiliankolb maximiliankolb deleted the refs_7096 branch September 29, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants