-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #36786 - Permit Symbol for YAML.safe_load report parser #9844
Conversation
The config is just for ActiveRecord. If you use YAML directly it doesn't apply. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you modify the commit message to say Symbol
instead of colon? Other than that 👍
9c0aea1
to
8ea8c64
Compare
Thanks for the comment, I've changed the commit message accordingly 🙌 |
Marked as WIP to add some tests. |
8ea8c64
to
19f6f73
Compare
19f6f73
to
c411f55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekohl Added some tests here too. 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Take a look at the Foreman ticket for the issue explanation.
I assumed the issue shouldn't appear due to this config:
foreman/config/application.rb
Lines 201 to 210 in 2517ba4
But, it seems like the exception for
HashWithIndifferentAccess
has been added to theYAML.safe_load
call already (which is extended with this PR) - just the one forSymbol
is missing which leads to the issue described in the Foreman ticket.I might've gotten something wrong here tho 🤞