Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stale action to replace prprocessor #9828

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Sep 11, 2023

No description provided.

@evgeni
Copy link
Member Author

evgeni commented Sep 11, 2023

I tried my best to translate the logic from https://github.com/theforeman/prprocessor/blob/master/config/close_inactive.yaml and https://github.com/theforeman/prprocessor/blob/master/scripts/close_inactive.rb into actions/stale.

Technically, this now gives week more time as the workflow first marks things as "stale" (after 90 or 30 days) and only then after 7 days closes it. We can fine-tune that, but I didn't feel like it's a bad thing.

It's also explicitly configured to only touch PRs, even if we have issues disabled in this repo.

@evgeni
Copy link
Member Author

evgeni commented Sep 11, 2023

one thing that this does not do (and can't do too well), is removing the PR from the redmine.

I think that's OK tho?

@ekohl
Copy link
Member

ekohl commented Sep 11, 2023

one thing that this does not do (and can't do too well), is removing the PR from the redmine.

I think that's OK tho?

We can implement this in the regular PR processor: when a PR is closed without being merged we can remove the link. That would then also work for manual actions.

@evgeni
Copy link
Member Author

evgeni commented Sep 11, 2023

theforeman/foreman-infra#1896 - removes the cronjob
theforeman/prprocessor#180 - removes the code

@ekohl ekohl merged commit b24cf84 into theforeman:develop Sep 11, 2023
6 of 8 checks passed
@evgeni evgeni deleted the stale branch September 11, 2023 10:37
@ekohl
Copy link
Member

ekohl commented Sep 11, 2023

We can implement this in the regular PR processor: when a PR is closed without being merged we can remove the link. That would then also work for manual actions.

I think theforeman/prprocessor#182 would do that. At this point I haven't tried it out though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants