Fixes #37156 - Pin victory-core to 36.8.z #10043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is Foreman the correct place for it? We only use it in Katello.. |
I thought REX uses charts too..Let me check.. So I found it in these places in foreman project: https://github.com/search?q=org%3Atheforeman%20%40patternfly%2Freact-charts&type=code |
|
@evgeni Does this look good? |
MariaAga
reviewed
Feb 13, 2024
MariaAga
reviewed
Feb 13, 2024
| @@ -28,7 +28,8 @@ | |||
| "surge", | |||
| "webpack-bundle-analyzer", | |||
| "tabbable", | |||
| "@adobe/css-tools" | |||
| "@adobe/css-tools", | |||
| "victory-core" | |||
There was a problem hiding this comment.
I am not seeing this packaged today so not sure we want to package it..
There was a problem hiding this comment.
@evgeni Is this supposed to exclude only dev dependencies?
There was a problem hiding this comment.
I'm unsure about this change, but the list must remain sorted.
sjha4
force-pushed
the
pin-victory-core
branch
from
9dbc71d to
6db8442
Compare
evgeni
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin victory-core to less than 36.9.0 which breaks react-charts. See patternfly/patternfly-react#10064