Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require mask/cidr only on ipv4 #880

Merged
merged 4 commits into from
Jul 17, 2020
Merged

Conversation

mdellweg
Copy link
Member

fixes: #878

Additional benefit: You can absent the subnet without mask or cidr.

@evgeni evgeni linked an issue Jul 17, 2020 that may be closed by this pull request
@evgeni
Copy link
Member

evgeni commented Jul 17, 2020

the additional benefit had an issue: #345 -- added to linked and ack!

Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some picky comments ;)

plugins/modules/subnet.py Outdated Show resolved Hide resolved
plugins/modules/subnet.py Outdated Show resolved Hide resolved
plugins/modules/subnet.py Outdated Show resolved Hide resolved
mdellweg and others added 3 commits July 17, 2020 11:16
@evgeni
Copy link
Member

evgeni commented Jul 17, 2020

failure unrelated

@evgeni evgeni merged commit bc46d06 into theforeman:master Jul 17, 2020
@mdellweg mdellweg deleted the optional_netmask branch July 17, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make cidr/netmask optional for IPv6 subnets foreman_subnet: requires cidr or mask even for absent
2 participants