cv_version: ensure version param has a minor part #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
reviewed
Dec 8, 2020
| @@ -204,6 +204,13 @@ def main(): | |||
|
|
|||
| module.task_timeout = 60 * 60 | |||
|
|
|||
| if 'version' in module.foreman_params and '.' not in module.foreman_params['version']: | |||
There was a problem hiding this comment.
What if you get "2.3.4.5"? Should we check for exactly one '.'?
There was a problem hiding this comment.
So something like:
if 'version' in module.foreman_params and module.foreman_params['version'].count('.') != 1:
err_msg = "The 'version' needs to be in the format 'X.Y', not '{0}'".format(module.foreman_params['version'])
if module.foreman_params['version'].count('.') > 1:
module.fail_json(err_msg)
else:
try:
major_version = int(module.foreman_params['version'])
module.foreman_params['version'] = "{0}.0".format(major_version)
except ValueError:
module.fail_json(err_msg)still doesn't catch "what.lol" as a version, but I'd not go that far right now?
There was a problem hiding this comment.
i thought checking a regex like r"^(\d*)(?:\.(\d*))?$"
There was a problem hiding this comment.
I've just used ^\d+\.\d+$ and then relied on int() throwing a ValueError ;)
evgeni
commented
Dec 9, 2020
| if 'version' in module.foreman_params and '.' not in module.foreman_params['version']: | ||
| try: | ||
| major_version = int(module.foreman_params['version']) | ||
| module.foreman_params['version'] = "{0}.0".format(major_version) |
There was a problem hiding this comment.
should this branch emit a warning, so the user knows their playbook is not exactly correct?
There was a problem hiding this comment.
if hammer accepts it we should maybe also.
mdellweg
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.