Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 'None' Option for PXE Loader Selection #971

Closed
jjaswanson4 opened this issue Sep 22, 2020 · 2 comments · Fixed by #972
Closed

Support 'None' Option for PXE Loader Selection #971

jjaswanson4 opened this issue Sep 22, 2020 · 2 comments · Fixed by #972

Comments

@jjaswanson4
Copy link
Contributor

SUMMARY

'None' is an option within the webUI and the API, however the modules currently reject the option before firing off an API call.

FIX

Within plugins/module_utils/foreman_helper.py, add 'None' to pxe_loader=dict(choices)
@jjaswanson4
Copy link
Contributor Author

PR to Address

@jjaswanson4 jjaswanson4 mentioned this issue Sep 22, 2020
Merged
@evgeni evgeni linked a pull request Sep 22, 2020 that will close this issue
Add 'None' as an option for pxe-loader #972
Merged
@jjaswanson4
Copy link
Contributor Author

From the API docs:

(Pulled for hostgroup, also used elsewhere)

hostgroup[pxe_loader]optional
...
Validations:
Must be one of:
None, PXELinux BIOS, PXELinux UEFI, Grub UEFI, Grub2 BIOS, Grub2 ELF, Grub2 UEFI, Grub2 UEFI SecureBoot, Grub2 UEFI HTTP, Grub2 UEFI HTTPS, Grub2 UEFI HTTPS SecureBoot, iPXE Embedded, iPXE UEFI HTTP, iPXE Chain BIOS, iPXE Chain UEFI.

jjaswanson4 added a commit to jjaswanson4/foreman-ansible-modules that referenced this issue Sep 22, 2020
@jjaswanson4
Create changelog Fragment
6be28cc 
Tie to theforeman#971
evgeni pushed a commit that referenced this issue Sep 22, 2020
@jjaswanson4
Add 'None' as an option for pxe-loader (#972)
2bad049 
* Add 'None' as an option for pxe-loader

This option is selectable in the WebUI and available via the satellite API

* Update documentation for pxe_loader to Include 'None'

Adding 'None' under choices for pxe_loader

* Create changelog Fragment

Tie to #971
evgeni added a commit to evgeni/foreman-ansible-modules that referenced this issue Oct 2, 2020
@evgeni
fix changelog fragment path for theforeman#971
405fb4a
ehelms pushed a commit that referenced this issue Oct 2, 2020
@evgeni @ehelms
fix changelog fragment path for #971
1bcad16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 'None' as an option for pxe-loader jjaswanson4/foreman-ansible-modules
1 participant
@jjaswanson4