Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBT-2XS rogue high temp fix #154

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conversation

DigiH
Copy link
Member

@DigiH DigiH commented Jul 18, 2022

Fix for

https://community.openmqttgateway.com/

While I initially thought it was a good idea to shorten the manufacturerdata comparison from "index", 0, "00000000" to "index", 2, "000000" in

#110

to include both 2X and 2XS versions in one decoder, it wasn't then clear that the IBT-2XS also sends 02 prefixed manufacturerdata of weirdly unrealistic high temperatures every now and then :)

We might want to wait just a bit before merging just to see if the other user also has the same 02 occurrences.

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@DigiH
Copy link
Member Author

DigiH commented Jul 19, 2022

I think we can actually merge this, as it's very unlikely that the other user's issues isn't the same 02 prefixed manufacturerdata, and even it it was still happening with the now defined

… "manufacturerdata", "=", 28, "index", 0, "00000000", "|","manufacturerdata", "=", 28, "index", 0, "01000000"

there wouldn't be much we could do about it on the decoder side.

What do you say?

@1technophile
Copy link
Member

I say let's go!

@DigiH DigiH merged commit 1799b51 into theengs:development Jul 19, 2022
@DigiH DigiH deleted the IBT-2XS-roguetemp-fix branch July 19, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants