Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for
https://community.openmqttgateway.com/
While I initially thought it was a good idea to shorten the manufacturerdata comparison from
"index", 0, "00000000"
to"index", 2, "000000"
in#110
to include both 2X and 2XS versions in one decoder, it wasn't then clear that the IBT-2XS also sends 02 prefixed manufacturerdata of weirdly unrealistic high temperatures every now and then :)
We might want to wait just a bit before merging just to see if the other user also has the same 02 occurrences.
Checklist: