Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service UUID to condition of LYWSD02 decoder #147

Merged

Conversation

koenvervloesem
Copy link
Member

Description:

This adds a check of the service data UUID to the LYWSD02 decoder, as suggested in #146.

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@DigiH
Copy link
Member

DigiH commented Jul 8, 2022

Thanks

I think this might also be a good idea for many other Xiaomi decoders, to narrow down the model conditions with servicedata UUID and solely the product id.

@koenvervloesem @1technophile do you have any other of these devices to confirm this suggestion?

@DigiH DigiH merged commit f5b29b6 into theengs:development Jul 8, 2022
@koenvervloesem
Copy link
Member Author

I have a Mi Flora, I'll investigate later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants