bit_static_value decoder function #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h2zero
reviewed
May 25, 2022
Initial Test with SwitchBot Bot, Xiaomi Scales and CGH1 decoder compression Improved code reduction with @h2zero's suggestion • condensed getBinaryData to its own function, it being called twice • commented out the UPPER case condition, as all presented data should only be lower case • commented out the static_value bool cast, as this doesn't seem to be necessary any longer
DigiH
force-pushed
the
static-bitwise-test
branch
from
6e99c18 to
4c32888
Compare
|
This enables a good cleanup, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New "bit_static_value" decoder function
Implementation in SwitchBot devices, Xiaomi scales and CGH1 decoders.
Updated docs.
Checklist: