Add nesting and NOT condition support for device conditions. #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h2zero
force-pushed
the
check-dev-match-func
branch
2 times, most recently
from
91b61b9 to
d32ac53
Compare
* Conditions for device detection can now use nested JSON arrays to allow more specific evaluation. * Device conditions can now support a NOT operation when the condition check type "index" and a "!" is preceded before the value to test for.
h2zero
force-pushed
the
check-dev-match-func
branch
from
d32ac53 to
13a4e32
Compare
DigiH
reviewed
Mar 28, 2022
DigiH
reviewed
Mar 28, 2022
|
Hi @h2zero, wasn't sure if I could just correct the typos in the file, so marked them up. Thanks for this addition, even if mainly discouraged and still possible without the bracketed nesting! |
|
Feel free to push changes to the branch if you like. I probably shouldn't write docs after a couple wobbly pops 🙃. |
LOL ok, will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
checkDeviceMatchChecklist: