feat: use currentBranch for diff if it has already been pushed to remote #30
Conversation
|
@theenadayalank Based on work in #31 I'm updating this PR to use the remote |
ericrallen
force-pushed
the
feature/check-remote-branch
branch
from
c474f6d to
3ab8bfa
Compare
| @@ -3,7 +3,7 @@ const { execChildProcess } = require("./common"); | |||
| module.exports = function fetchGitDiff( baseBranch = "master" ) { | |||
|
|
|||
| // git command to pull out the changed file names between current branch and base branch (Excluded delelted files which cannot be fetched now) | |||
| let command = `git diff --relative --name-only --diff-filter=d ${baseBranch}...HEAD`; | |||
| let command = `git diff --relative --name-only --diff-filter=d ${baseBranch}`; | |||
There was a problem hiding this comment.
I couldn't get the motive here. Can you shed some light here?
There was a problem hiding this comment.
...HEAD wasn't cooperating with the remote branch.
There was a problem hiding this comment.
IMO, it should. Can you explain it in more detail for further clarification?
There was a problem hiding this comment.
I have tried a few use cases with ...HEAD, it is working as intended for me.
There was a problem hiding this comment.
I think this PR is good to go after resolving this discussion 🔜 . Please make sure that the PR doesn't have any conflicts with the master 😉
|
Closing this PR. Hence, the commits have been moved to #66 |
This PR introduces a check to see if the
currentBranchhas already been pushed to the remote. If it has, we will use it for thediffinstead of thebaseBranch.Closes #26