Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only search browsable fields #5281

Merged
merged 2 commits into from
May 1, 2021
Merged

Only search browsable fields #5281

merged 2 commits into from
May 1, 2021

Conversation

emptynick
Copy link
Collaborator

@emptynick emptynick commented Apr 1, 2021

When using server-side pagination, all fields are shown in the search dropdown and are searchable, even when they are unticked in BREAD.
This PR prevents this behaviour as a non-browsable field should not be searchable.

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #5281 (43c3f35) into 1.4 (3c2d314) will increase coverage by 0.08%.
The diff coverage is 40.00%.

❗ Current head 43c3f35 differs from pull request most recent head 00f2c54. Consider uploading reports for the commit 00f2c54 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##                1.4    #5281      +/-   ##
============================================
+ Coverage     63.37%   63.45%   +0.08%     
+ Complexity     1394     1393       -1     
============================================
  Files           195      195              
  Lines          4120     4116       -4     
============================================
+ Hits           2611     2612       +1     
+ Misses         1509     1504       -5     
Impacted Files Coverage Δ Complexity Δ
src/Http/Controllers/VoyagerBaseController.php 61.53% <40.00%> (+0.79%) 147.00 <0.00> (-1.00) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c2d314...00f2c54. Read the comment docs.

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2021

Codecov Report

Merging #5281 (c6d87c8) into 1.4 (e22d212) will increase coverage by 0.08%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.4    #5281      +/-   ##
============================================
+ Coverage     63.37%   63.45%   +0.08%     
+ Complexity     1394     1393       -1     
============================================
  Files           195      195              
  Lines          4120     4116       -4     
============================================
+ Hits           2611     2612       +1     
+ Misses         1509     1504       -5     
Impacted Files Coverage Δ Complexity Δ
src/Http/Controllers/VoyagerBaseController.php 61.53% <40.00%> (+0.79%) 147.00 <0.00> (-1.00) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e22d212...c6d87c8. Read the comment docs.

@emptynick emptynick merged commit c819b66 into 1.4 May 1, 2021
@emptynick emptynick deleted the 1.x-browsable-fields branch August 31, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants