Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old image not removed on update #5196

Merged

Conversation

MrCrayon
Copy link
Collaborator

When image filed is used and a new image is uploaded the old one was not removed.

Fixes #2264

@codecov
Copy link

codecov bot commented Jan 10, 2021

Codecov Report

Merging #5196 (42a0ed4) into 1.4 (ed3fe6e) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.4    #5196      +/-   ##
============================================
+ Coverage     63.26%   63.31%   +0.05%     
  Complexity     1379     1379              
============================================
  Files           194      194              
  Lines          4064     4070       +6     
============================================
+ Hits           2571     2577       +6     
  Misses         1493     1493              
Impacted Files Coverage Δ Complexity Δ
src/Http/Controllers/VoyagerBaseController.php 57.66% <100.00%> (+0.62%) 143.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed3fe6e...42a0ed4. Read the comment docs.

@emptynick emptynick merged commit 1732bee into thedevdojo:1.4 Jan 28, 2021
@MrCrayon MrCrayon deleted the fix-old-image-not-deleted-on-update branch February 11, 2021 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old image not deleted after updating image field
2 participants