Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQL Issue with multiple orderBy('order') #4985

Merged
merged 4 commits into from
Jul 6, 2020
Merged

Fix SQL Issue with multiple orderBy('order') #4985

merged 4 commits into from
Jul 6, 2020

Commits on Jun 18, 2020

  1. Fix SQL Issue with multiple orderBy('order')

    Fixing SQL Issue: A column has been specified more than once in the order by list. Columns in the order by list must be unique.
    
    Just had this issue on a MsSQL server. Whenever the menu items should be shown, I was facing the error from above. And I figured out, that there is indeed the `orderBy('order')` applied multiple times: Once in `Menu::display()` and the other time in the relationship itself, on `MenuItem::children`. 
    
    Since I think it makes somehow sense to sort the MenuItems per default, I decided to remove the `orderBy` in the `Menu::display` method. But this MR is just to share the awareness of the issue, so feel free to do something else to fix the issue 😉
    
    Have a great day! 😁
    tjventurini authored Jun 18, 2020
    Configuration menu
    Copy the full SHA
    a9f2543 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2020

  1. Remove ordering from model

    emptynick committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    4521b25 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    187c2fb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5ed67eb View commit details
    Browse the repository at this point in the history