Filesize method can return false but is not detected by Safe

generated/filesystem.php

@@ -449,6 +449,26 @@ function fileowner(string $filename): int
 }
 
 
+/**
+ * Gets the size for the given file.
+ *
+ * @param string $filename Path to the file.
+ * @return int Returns the size of the file in bytes, or FALSE (and generates an error
+ * of level E_WARNING) in case of an error.
+ * @throws FilesystemException
+ *
+ */
+function filesize(string $filename): int
+{
+    error_clear_last();
+    $result = \filesize($filename);
+    if ($result === false) {
+        throw FilesystemException::createFromPhpError();
+    }
+    return $result;
+}
+
+
 /**
  * flock allows you to perform a simple reader/writer
  * model which can be used on virtually every platform (including most Unix

generated/functionsList.php

@@ -145,6 +145,7 @@
     'fileinode',
     'filemtime',
     'fileowner',
+    'filesize',
     'flock',
     'fopen',
     'fputcsv',

generated/pcre.php

@@ -377,7 +377,7 @@ function preg_match_all(string $pattern, string $subject, array &$matches = null
  *
  *
  * If this flag is passed, for every occurring match the appendant string
- * offset will also be returned. Note that this changes the value of
+ * offset (in bytes) will also be returned. Note that this changes the value of
  * matches into an array where every element is an
  * array consisting of the matched string at offset 0
  * and its string offset into subject at offset
@@ -461,7 +461,7 @@ function preg_match_all(string $pattern, string $subject, array &$matches = null
  *
  *
  * If this flag is passed, for every occurring match the appendant string
- * offset will also be returned. Note that this changes the value of
+ * offset (in bytes) will also be returned. Note that this changes the value of
  * matches into an array where every element is an
  * array consisting of the matched string at offset 0
  * and its string offset into subject at offset
@@ -538,7 +538,7 @@ function preg_match_all(string $pattern, string $subject, array &$matches = null
  *
  * The above example will output:
  * @param int $offset If this flag is passed, for every occurring match the appendant string
- * offset will also be returned. Note that this changes the value of
+ * offset (in bytes) will also be returned. Note that this changes the value of
  * matches into an array where every element is an
  * array consisting of the matched string at offset 0
  * and its string offset into subject at offset

generator/src/DocPage.php

@@ -48,6 +48,9 @@ public function detectFalsyFunction(): bool
         if (preg_match('/&date.datetime.return.modifiedobjectorfalseforfailure;/m', $file)) {
             return true;
         }
+        if (preg_match('/ or &false; \\(and generates an error/m', $file)) {
+            return true;
+        }
 
         return false;
     }

generator/tests/DocPageTest.php

@@ -11,10 +11,12 @@ public function testDetectFalsyFunction() {
         $implode = new DocPage(__DIR__ . '/../doc/doc-en/en/reference/strings/functions/implode.xml');
         $getCwd = new DocPage(__DIR__ . '/../doc/doc-en/en/reference/dir/functions/getcwd.xml');
         $setTime = new DocPage(__DIR__ . '/../doc/doc-en/en/reference/datetime/datetime/settime.xml');
+        $filesize = new DocPage(__DIR__ . '/../doc/doc-en/en/reference/filesystem/functions/filesize.xml');
 
         $this->assertTrue($pregMatch->detectFalsyFunction());
         $this->assertFalse($implode->detectFalsyFunction());
         $this->assertTrue($getCwd->detectFalsyFunction());
         $this->assertTrue($setTime->detectFalsyFunction());
+        $this->assertTrue($filesize->detectFalsyFunction());
     }
 }

rector-migrate.yml

@@ -146,6 +146,7 @@ services:
       fileinode: 'Safe\fileinode'
       filemtime: 'Safe\filemtime'
       fileowner: 'Safe\fileowner'
+      filesize: 'Safe\filesize'
       flock: 'Safe\flock'
       fopen: 'Safe\fopen'
       fputcsv: 'Safe\fputcsv'