Fix regex matching for removed functions #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Dec 2, 2024
| @@ -32,8 +32,8 @@ private function getIsDeprecated(string $file): bool | |||
| } | |||
| } | |||
|
|
|||
| if (preg_match('/&warn\.removed\.function-(\d+-\d+-\d+)/', $file, $matches) && isset($matches[2])) { | |||
| $removedVersion = $matches[2]; | |||
| if (preg_match('/&warn\.removed\.function-(\d+-\d+-\d+)/', $file, $matches)) { | |||
There was a problem hiding this comment.
this bug would have been found by PHPStan.
should we enable PHPStan coverage via /phpstan.neon for generator/src/ ?
(separate PR)
There was a problem hiding this comment.
Probably yes, but my top priority is getting shish/safe and tcm/safe in-sync so that we can get some green automated tests as a base to work from
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(pulling fixes from shish/safe into tcm/safe one at a time)