Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change signatures for openssl_sign to Adapt to php8+ #420

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BadJacky
Copy link

In PHP8+, there is a new return type OpenSSLAsymmetricKey on the function openssl_pkey_get_private , but the safe\openssl_sign does not allow this type as the private_key parameter.

You can get details from the changed files and let me know if you have other questions.

@Kharhamel
Copy link
Collaborator

You cannot juste edit the generated files, or your change will be overwritten when we generate from the doc. You need to edit the file CustomPhpStanFunctionMap.php to overwrite the typings

@BadJacky
Copy link
Author

You cannot juste edit the generated files, or your change will be overwritten when we generate from the doc. You need to edit the file CustomPhpStanFunctionMap.php to overwrite the typings

You are right! I have changed the CustomPhpStanFunctionMap.php and pushed it again.

@BadJacky
Copy link
Author

Hi @Kharhamel ,
I noticed that you're preparing for the V3.0 release and I have encountered some errors that seem to be similar to yours. After some investigation, I found that fixing the errors would require us to address the documentation, as the generator depends on it. The exceptions include, but are not limited to, issues with gmp.
I was wondering if you're currently working on fixing these errors? If not, I'd be happy to collaborate with you on resolving them.
I have attached the fixed results image and let me know if you encountered any questions and I'm glad to fix them with you!
Screenshot 2023-04-17 at 07 17 20
Screenshot 2023-04-17 at 07 19 24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants