FIX: Fix openssl_pkey_get_* functions #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinssipenko
changed the title
|
Thanks a lot, I will try to deploy this this week end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the input and output of the
openssl_pkey_get_privatefunction as starting from PHP 8.0 it accepts:\OpenSSLAsymmetricKey|\OpenSSLCertificate|array|stringfor$private_keynull|stringfor$passphraseand returns
OpenSSLAsymmetricKey|false.Fixed the input and output of the
openssl_pkey_get_publicfunction as starting from PHP 8.0 it accepts:\OpenSSLAsymmetricKey|\OpenSSLCertificate|array|stringfor$public_keyand returns
OpenSSLAsymmetricKey|false.Added
openssl_pkey_get_detailsfunction as it's actually falsy, but was not picked up by automatic code generation because of wording in PHP docs, but now is after this change.