FIX: Deprecated array_replace and array_replace_recursive

[Kharhamel]

No description provided.

[codecov-commenter]

Codecov Report

Merging #369 (09b43b1) into master (0cdbee9) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #369      +/-   ##
============================================
- Coverage     49.55%   49.43%   -0.13%     
  Complexity      313      313              
============================================
  Files            16       16              
  Lines           791      791              
============================================
- Hits            392      391       -1     
- Misses          399      400       +1     

Impacted Files	Coverage Δ
generator/src/DocPage.php	79.61% <0.00%> (-0.64%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cdbee9...09b43b1. Read the comment docs.

[shadowhand]

Is there some documentation that explains why some functions get deprecated? I'm all for native when possible, but I'd like to understand why Safe alternative functions are no longer recommended.

[JacekAndrzejewski]

Is there some documentation that explains why some functions get deprecated? I'm all for native when possible, but I'd like to understand why Safe alternative functions are no longer recommended.

Looking at the code it seems that those could never throw, and looking at PHP docs it looks like those two functions always return arrays (now). So this alternative was really not safer in any way.

[shadowhand]

@JacekAndrzejewski thanks!

[Kharhamel]

Is there some documentation that explains why some functions get deprecated? I'm all for native when possible, but I'd like to understand why Safe alternative functions are no longer recommended.

The whole library is synced with the official documentation, so when they randomly edit a function page to state that it doesn't return false/null anymore, we have to drop support for this function.
Bu since I try to respect semVer, i deprecate them instead.