Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supplementing the rule #62

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Rules/Exceptions/ThrowMustBundlePreviousExceptionRule.php
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ public function leaveNode(Node $node)
if ($node->name === $this->catchedVariableName) {
$this->exceptionUsedCount++;
}
if ($node->getAttribute('parent') instanceof Node\Expr\New_) {
$this->exceptionUsedCount--;
}
return null;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ public function testCheckCatchedException()
'Thrown exceptions in a catch block must bundle the previous exception (see throw statement line 28). More info: http://bit.ly/bundleexception',
26,
],
[
'Thrown exceptions in a catch block must bundle the previous exception (see throw statement line 40). More info: http://bit.ly/bundleexception',
38,
],
]);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,10 @@ class MyCatchException extends \Exception
}catch (\Exception) {
// This is okay
throw new \Exception();
}
}

try {
} catch (\Exception $e) {
// This is not okay
throw new $e;
}