Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer: allow instal with PHP 8.0 code #56

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

TomasVotruba
Copy link
Contributor

No description provided.

@TomasVotruba
Copy link
Contributor Author

Any ETA on this? It's the last blocker for Rector to use PHP 8.0
https://github.com/rectorphp/rector/pull/4082/checks?check_run_id=1083741640

@moufmouf
Copy link
Member

moufmouf commented Sep 8, 2020

Sorry, I skiped the first notification. Let's merge this!

@moufmouf moufmouf merged commit 4bb334f into thecodingmachine:master Sep 8, 2020
@TomasVotruba TomasVotruba deleted the patch-1 branch September 8, 2020 09:14
@TomasVotruba
Copy link
Contributor Author

TomasVotruba commented Sep 8, 2020

Thanks 👍

Any ETA on tagging so I can use it as 3rd party dependency?
I had to remove it from Rector for now, because the CI does not allow me to install it on PHP 8.0 and we need tagged dependencies so people can install Rector to their project.

@moufmouf
Copy link
Member

moufmouf commented Sep 8, 2020

Hey Tomas!

It is tagged: https://github.com/thecodingmachine/phpstan-strict-rules/releases/tag/v0.12.1

@TomasVotruba
Copy link
Contributor Author

Epic support 👏 thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants