Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary try block #152

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Remove unnecessary try block #152

merged 1 commit into from
Jul 8, 2024

Conversation

Steelskin
Copy link
Contributor

@Steelskin Steelskin commented Jun 28, 2024 •
edited
Loading

  • Remove an unnecessary try block, the code in the block cannot throw.
  • Move a defer closure earlier to make flow clearer.

@Steelskin
Remove unnecessary try block
44eacd8 
* Remove an unnecessary try block, the code in the block cannot throw.
* Move a defer closure earlier to make flow clearer.
@Steelskin Steelskin force-pushed the fabrice/win-app-driver-try-block branch from 10c7f32 to 44eacd8 Compare June 28, 2024 20:29
tristanlabelle
tristanlabelle approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@tristanlabelle tristanlabelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up!

@Steelskin Steelskin merged commit 34d6a32 into main Jul 8, 2024
4 checks passed
@Steelskin Steelskin deleted the fabrice/win-app-driver-try-block branch July 8, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristanlabelle tristanlabelle tristanlabelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Steelskin @tristanlabelle