Update Psalm to latest 5.14.0, and remove usage of deprecated withCon… #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #580 +/- ##
==========================================
Coverage 72.38% 72.38%
Complexity 762 762
==========================================
Files 67 67
Lines 2991 2991
==========================================
Hits 2165 2165
Misses 826 826 ☔ View full report in Codecov by Sentry. |
…secutive from PHPUnit I ran: docker-compose exec app composer update -W vimeo/psalm Changes: doctrine/deprecations (v1.0.0 => v1.1.1) symfony/deprecation-contracts (v3.2.0 => v3.3.0) symfony/string (v6.2.2 => v6.3.2) symfony/console (v6.2.3 => v6.3.2) symfony/filesystem (v6.2.0 => v6.3.1) phpstan/phpdoc-parser (1.23.0) phpdocumentor/type-resolver (1.6.2 => 1.7.2) netresearch/jsonmapper (v4.1.0 => v4.2.0) fidry/cpu-core-counter (0.4.1 => 0.5.1) spatie/array-to-xml (2.17.1 => 3.2.0) sebastian/type (3.2.0 => 3.2.1) sebastian/recursion-context (4.0.4 => 4.0.5) sebastian/environment (5.1.4 => 5.1.5) sebastian/diff (4.0.4 => 4.0.5) nikic/php-parser (v4.15.2 => v4.16.0) phpunit/php-code-coverage (9.2.23 => 9.2.27) myclabs/deep-copy (1.11.0 => 1.11.1) phpunit/phpunit (9.5.28 => 9.6.10) phpspec/prophecy (v1.16.0 => v1.17.0) vimeo/psalm (5.13.0 => 5.14.0)
bdsl
commented
Jul 31, 2023
| ->willReturnCallback(fn(array $constraint) => match ($constraint) { | ||
| ['salesforceId' => 'sfFundId123'] => $existingFundNonShared, | ||
| ['salesforceId' => 'sfFundId456'] => $existingFundShared, | ||
| }); |
There was a problem hiding this comment.
NoelLH
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…secutive from PHPUnit
I ran:
docker-compose exec app composer update -W vimeo/psalm
Changes:
doctrine/deprecations (v1.0.0 => v1.1.1)
symfony/deprecation-contracts (v3.2.0 => v3.3.0)
symfony/string (v6.2.2 => v6.3.2)
symfony/console (v6.2.3 => v6.3.2)
symfony/filesystem (v6.2.0 => v6.3.1)
phpstan/phpdoc-parser (1.23.0)
phpdocumentor/type-resolver (1.6.2 => 1.7.2)
netresearch/jsonmapper (v4.1.0 => v4.2.0)
fidry/cpu-core-counter (0.4.1 => 0.5.1)
spatie/array-to-xml (2.17.1 => 3.2.0)
sebastian/type (3.2.0 => 3.2.1)
sebastian/recursion-context (4.0.4 => 4.0.5)
sebastian/environment (5.1.4 => 5.1.5)
sebastian/diff (4.0.4 => 4.0.5)
nikic/php-parser (v4.15.2 => v4.16.0)
phpunit/php-code-coverage (9.2.23 => 9.2.27)
myclabs/deep-copy (1.11.0 => 1.11.1)
phpunit/phpunit (9.5.28 => 9.6.10)
phpspec/prophecy (v1.16.0 => v1.17.0)
vimeo/psalm (5.13.0 => 5.14.0)