Merge pull request #12 from thebiggive/CLA-19-fix-missing-msg

CLA-19 – fix surfacing developer detail as 'message' in biz errors
thebiggive · Apr 19, 2022 · 52c761f · 52c761f
2 parents 7b8671b + 0e08c41
commit 52c761f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/GiftAid.php b/src/GiftAid.php
@@ -1180,6 +1180,7 @@ public function getResponseErrors()
 
                 $govTalkErrors['business'][] = [
                     'number'   => (string) $gaError->Number,
+                    'message'  => $gaError->Application->Messages->DeveloperMessage ?? '',
                     'text'     => (string) $gaError->Text,
                     'location' => (string) $gaError->Location,
                     'donation_id' => $donationId,

diff --git a/tests/GovTalk/GiftAid/GiftAidTest.php b/tests/GovTalk/GiftAid/GiftAidTest.php
@@ -492,6 +492,11 @@ public function testMultiClaimSubmissionWithFirstDonationNamesMissing(): void
         $this->assertCount(0, $response['errors']['warning']);
         $this->assertCount(4, $response['errors']['business']);
 
+        $this->assertEquals(
+            "cvc-type.3.1.3: The value '' of element 'Sur' is not valid.",
+            $response['errors']['business'][1]['message'],
+        );
+
         $this->assertEquals(
             "Invalid content found at element 'Sur'",
             $response['errors']['business'][1]['text'],